search

chaos / powerman

cluster power control
GNU General Public License v2.0
43 stars 19 forks source link

Add redfishpower HPE Cray EX chassis device file #173

Closed chu11 closed 6 months ago

chu11 commented 7 months ago

Built on top of #167 and #172, but those don't have to go in first. #167 is a "pretty nice to have" (would like to have before release), #172 can be debated before release if it should go in.

chu11 commented 7 months ago

re-pushed, its no longer based on #172, it was far less necessary for this PR compared to #167 nevermind, strike that ... i have tests that assume the --diag support :-) ... we can debate if those should be ripped out or not.

chu11 commented 7 months ago

re-pushed, rebasing on #172. mostly just updating the tests, "diagnostic" error messages are now by default (no --diag), to stderr, and one per line

garlick commented 7 months ago

The dependent PRs are approved so I'll wait to review this until it's rebased on master after those are merged if that's OK.

chu11 commented 7 months ago

re-pushed, rebasing on master and fixing up tests given new error message output possibilities

garlick commented 7 months ago

For a start, could we just propose the one spec in this PR, for the fully populated chassis, drop the inline documentation, and shorten the name to "cray-ex" or similar?

chu11 commented 6 months ago

ok, re-pushed per your comments above. We'll split out rabbit config into it's own PR later.

chu11 commented 6 months ago

re-pushed per comments above!

chu11 commented 6 months ago

re-pushed, tweaking the one thing commented on above. if we decide to change default username/password will put into a follow up PR.

chu11 commented 6 months ago

doh! good catches ... re-pushed with those two tweaks above