chaos / powerman

cluster power control
GNU General Public License v2.0
43 stars 19 forks source link

redfishpower tests fail if redfishpower is not configured #178

Closed garlick closed 6 months ago

garlick commented 6 months ago

Problem: refishpower is not built unless explicitly enabled on the configure line, but tests run unconditionally (and fail).

We actually might want to just enable redfishpower by default?

chu11 commented 6 months ago

I think I was just copying and pasting

  --with-httppower        Build httppower executable
  --with-redfishpower     Build redfishpower executable
  --with-snmppower        Build snmppower executable

when I added redfishpower. Anything stopping us from building all of these all the time?

garlick commented 6 months ago

So the dependencies are

Seems pretty minimal. I guess I'm OK with going ahead with that. We can always restore some opt-out logic if we need to later on.

chu11 commented 6 months ago

just realized .... we could also skip redfishpower tests if it isn't configured? That seems a lot easier.

Something as simple as if the binary is in src/redfishpower run tests, else skip em all?

Edit: even easier, remove those tests in the makefile?

chu11 commented 6 months ago

per offline discussion, perhaps easier change is make options opt-out vs opt-in (i.e. --without-httppower, etc.)