chaos / powerman

cluster power control
GNU General Public License v2.0
43 stars 19 forks source link

redfishpower: command line option: resolve-hosts = not set #207

Closed garlick closed 1 month ago

garlick commented 1 month ago

Problem: looks like some debug was left in redfishpower when --resolve-hosts was added.

When running t0039-llnl-el-capitan-cluster.t -v I got a stream of these

command line option: resolve-hosts = not set
command line option: resolve-hosts = not set
command line option: resolve-hosts = not set
command line option: resolve-hosts = not set
command line option: resolve-hosts = not set
chu11 commented 1 month ago

that was semi intentional along w/ some other debugging

        /* output settings of command line options that can't be tested in test mode */                                                     
        if (header)                                                                                                                         
            fprintf(stderr, "command line option: header = %s\n", header);                                                                  
        if (userpwd)                                                                                                                        
            fprintf(stderr, "command line option: auth = %s\n", userpwd);                                                                   
        if (message_timeout != MESSAGE_TIMEOUT_DEFAULT)                                                                                     
            fprintf(stderr, "command line option: message timeout = %ld\n", message_timeout);                                               
        fprintf(stderr, "command line option: resolve-hosts = %s\n",                                                                        
                resolve_hosts ? "set" : "not set");         

perhaps should only output if it is set.

garlick commented 1 month ago

Or maybe only if a verbose option is set, which could be set in testing?

chu11 commented 1 month ago

This debug output is only under test-mode, which is the mode in the redfishpower sharness tests. So for most tests it just outputs that stray "resolve-hosts = not set" line. It's only under the giant el cap test it outputted a ton of them.

garlick commented 1 month ago

Oh OK then. Well, should we turn off test mode in the el cap test or is it required for some purpose?

garlick commented 1 month ago

Oh duh, never mind, your other PR is going to cut down on the noise.