Closed pete4abw closed 9 years ago
Thanks. A few changes please:
-X only takes one directory name
. We're not listing all the options that work here.char freespacedir[13];
and a later strcpy. Instead use static initialization without a size.construct relative path to temp directory in snprint
-X base diirectory %s does not exists
Thanks for the feedback. I'll clean up tomorrow. Will resync and make consistent.
Peter Hyman +1(609)598-0262 Sent from mobile. Sorry for any typos.
On February 11, 2015 6:36:24 PM EST, Jim Garlick notifications@github.com wrote:
Thanks. A few changes please:
- squash these commits since second one modifies changes in the first one
- refer to directory argument as "directory" or "dir" not "basedir" (be consistent)
- don't change the error
-X only takes one directory name
. We're not listing all the options that work here.- instead of
char freespacedir[13];
and a later strcpy. Instead use static initialization without a size.- drop comment
construct relative path to temp directory in snprint
- fix directory spellling and s on exists in
-X base diirectory %s does not exists
Reply to this email directly or view it on GitHub: https://github.com/chaos/scrub/pull/2#issuecomment-73988849
Further updates to scrub_free and -X handling. Now requires a base directory to exist and will create a random directory under using mkdtemp(). Also made slight change to man page to clarify -X option handling.