search

chaosbastler / opentraining

Android App for planing your fitness training.
GNU General Public License v3.0
80 stars 57 forks source link

Display description if there's no image #35

Open chaosbastler opened 10 years ago

chaosbastler commented 10 years ago

The app should display the description of the exercise when there is no image but an description.

christopherfowers commented 9 years ago

Some of these descriptions seem rather short and non-descriptive. For example Arnold Shoulder Press. Is this something that I should still use or was there another one that I should be focused on? Also, is there a preferred font and font size?

chaosbastler commented 9 years ago

I had a look at the Arnold Shoulder Press - it has a link to a youtube video. Making this link clickable (start an Intent) would make the description usefull again. Of course pictures would be much better. But displaying a bad description is often better than displaying nothing at all.

About font and size: just use the default values that android provides. If it seems too small feel free to change the size as you like.

christopherfowers commented 9 years ago

Pull request up

Sent from my Verizon 4G LTE Smartphone

----- Reply message ----- From: "Christian Skubich" notifications@github.com To: "chaosbastler/opentraining" opentraining@noreply.github.com Cc: "christopherfowers" cwfowers@gmail.com Subject: [opentraining] Display description if there's no image (#35) Date: Fri, Feb 27, 2015 1:58 PM

I had a look at the Arnold Shoulder Press - it has a link to a youtube video. Making this link clickable (start an Intent) would make the description usefull again.

Of course pictures would be much better. But displaying a bad description is often better than displaying nothing at all.

About font and size: just use the default values that android provides. If it seems too small feel free to change the size as you like.

— Reply to this email directly or view it on GitHub.