search

chaoseng / wg-chaoseng

Chaos Engineering Working Group
Apache License 2.0
113 stars 34 forks source link

Skeleton whitepaper #39

Closed veggiemonk closed 6 years ago

veggiemonk commented 6 years ago

Related to #3

Lawouach commented 6 years ago

Thanks a lot @veggiemonk!

Should we all work on that branch and merge later on? Or should we merge and work from master directly?

(cc @caniszczyk)

veggiemonk commented 6 years ago

If we merge it directly, it would be nice to put a message saying that the document is a draft and is changing. The advantage of having the change directly in master makes the merging is easier (but not always easy in case of multiple edit on the same part).

On the other hand, leaving the change in a branch/PR might slow down the iteration because we don't know when a PR is good enough to be merged.

So I would suggest to merge as fast as possible in master and get comfortable at making small PR that are easy to review and merge.

What do you think?

caniszczyk commented 6 years ago

I prefer to merge directly

On Tue, Jun 26, 2018 at 1:37 AM, Julien Bisconti notifications@github.com wrote:

If we merge it directly, it would be nice to put a message saying that the document is a draft and is changing. The advantage of having the change directly in master makes the merging is easier (but not always easy in case of multiple edit on the same part).

On the other hand, leaving the change in a branch/PR might slow down the iteration because we don't know when a PR is good enough to be merged.

So I would suggest to merge as fast as possible in master and get comfortable at making small PR that are easy to review and merge.

What do you think?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/chaoseng/wg-chaoseng/pull/39#issuecomment-400195870, or mute the thread https://github.com/notifications/unsubscribe-auth/AAD5IaPtBN6dGJQzwwIMf1Aq0SoZ8LpCks5uAda2gaJpZM4U3TJv .

-- Cheers,

Chris Aniszczyk http://aniszczyk.org +1 512 961 6719