chaosfire / vdrift-ogre

Automatically exported from code.google.com/p/vdrift-ogre
0 stars 0 forks source link

Random problems in the 1.8 code #179

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Some fixes for problems gcc gave warnings.
Some undefined behaviours if you read the small letter of the standard and a 
silly error handling one C string.

gcc also complains about aliasing. The problems should be fixed or the 
offending code compiled with -fno-strict-aliasing.

Original issue reported on code.google.com by Christia...@gmail.com on 30 Oct 2012 at 8:54

Attachments:

GoogleCodeExporter commented 8 years ago
Patch applied, thanks! 
https://github.com/stuntrally/stuntrally/commit/12b00ce87a6b199c33dfc5405e2cfa1d
b9a069db

Which version of GCC are you using and are there any extra compile flags, 
because I didn't saw those warnings when I did a full recompile and there seems 
to be no aliasing warnings either with my gcc 4.6.3.

Also, if you have further fixes, I think it would be easiest for everyone if we 
gave you a direct commit access (provided you know how to use git).

Original comment by tapiovie...@gmail.com on 30 Oct 2012 at 10:23

GoogleCodeExporter commented 8 years ago
I was packaging it for openSUSE and for sure it showed with openSUSE 12.2 (gcc 
4.7). But I am quite sure that it also appeared with openSUSE 12.1 (gcc 4.6) 
and 11.4 (gcc 4.5).

The CFLAGS where "-fmessage-length=0 -O2 -Wall -D_FORTIFY_SOURCE=2 
-fstack-protector -funwind-tables -fasynchronous-unwind-tables -g"

You can see the current build log (with -fno-strict-aliasing) at: 
https://build.opensuse.org/package/rawlog?arch=x86_64&package=stuntrally&project
=games&repository=openSUSE_12.2

My git knowledge is actually quite bad. And I don't have plans to look into the 
code for anything other than fix openSUSE packaging problems (which should be 
quite rare).

Original comment by crist...@samknows.com on 31 Oct 2012 at 12:25

GoogleCodeExporter commented 8 years ago

Original comment by Cry...@gmail.com on 6 Nov 2012 at 6:44

GoogleCodeExporter commented 8 years ago
closing.

Original comment by Cry...@gmail.com on 20 Nov 2012 at 5:55