search

chaosparrot / talon_hud

Unofficial Talon Head Up Display scripts
68 stars 29 forks source link

If a command phrase contains a walthrough command, a walkthrough step will highlight it even if the phrase is part of a larger completely different command. #19

Closed tararoys closed 2 years ago

tararoys commented 2 years ago

walktrhough Bug :

  1. when I was using cursorless in vscode, I said the phrase 'take look' to highlight a word.
  2. The walkthrough step I happened to have open had 'look' as a separate command.
  3. In the walkthrough, 'look' was highlighted green, even though I was saying the command 'take look' and not 'look'

This was in one of my markdown tutorlas, specifically on this step: 

The Talon phonetic alphabet allows you to spell quickly and accurately.  Let's spell the word Talon. Speaking as quickly or as slowly as you want, try saying the command phrase `trap` `air` `look` `odd` `near` into a text area.

image

tararoys commented 2 years ago

Same thing happens when saying 'ctrl-sun' to save a file on a walkthrough step with sun as a command.

chaosparrot commented 2 years ago

Thanks for the feedback!

Unfortunately, I cannot check where one part of a command ends, and another starts, in a single phrase. For instance, if someone would say trap made air look I would still want to make trap, air and look trigger, and not just trap. And especially for letters, which tend to be used in a lot of different commands like in cursorless or other configurations.

Would it be fine if I added ordering of the commands by default? Meaning: Trap air urge look would still trigger trap air and look, but urge look air trap would only trigger trap in the walkthrough step?

tararoys commented 2 years ago

i think command ordering is a sensible default, since the whole point of a walkthrough step. It would eliminate the vast majority of accidental highlights, too. I haven't checked recently if having the same command twice in the same step still highlights both commands, but command ordering would fix that problem too.

On Thu, Mar 17, 2022 at 14:10 Kevin te Raa @.***> wrote:

Thanks for the feedback!

Unfortunately, I cannot check where one part of a command ends, and another starts, in a single phrase. For instance, if someone would say trap made air look I would still want to make trap, air and look trigger, and not just trap. And especially for letters, which tend to be used in a lot of different commands like in cursorless or other configurations.

Would it be fine if I added ordering of the commands by default? Meaning: Trap air urge look would still trigger trap air and look, but urge look air trap would only trigger trap in the walkthrough step?

— Reply to this email directly, view it on GitHub https://github.com/chaosparrot/talon_hud/issues/19#issuecomment-1071234530, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAI4FFPO3TD2VHFVN3BCHZLVAN7T5ANCNFSM5Q7AONSQ . You are receiving this because you authored the thread.Message ID: @.***>

chaosparrot commented 2 years ago

Okay, I will make the command ordering chronological by default. That will be the last walkthrough change that I will make before I release the next version of the HUD which contains the improved walkthrough flow and widget.

chaosparrot commented 2 years ago

This has been added in the v0.6 release :) thanks!