search

chaoss / grimoirelab-elk

GNU General Public License v3.0
58 stars 121 forks source link

[Gitter] Enrichment Invalid IPV6 URL #1029

Open k----n opened 2 years ago

k----n commented 2 years ago

It seems like 

2022-01-31 00:25:04,762 - grimoire_elk.elk - ERROR - Error enriching raw from gitter (https://gitter.im/angular/angular): Invalid IPv6 URL
Traceback (most recent call last):
  File "/usr/local/lib/python3.7/dist-packages/grimoire_elk/elk.py", line 562, in enrich_backend
    enrich_count = enrich_items(ocean_backend, enrich_backend)
  File "/usr/local/lib/python3.7/dist-packages/grimoire_elk/elk.py", line 350, in enrich_items
    total = enrich_backend.enrich_items(ocean_backend)
  File "/usr/local/lib/python3.7/dist-packages/grimoire_elk/enriched/enrich.py", line 393, in enrich_items
    rich_item = self.get_rich_item(item)
  File "/usr/local/lib/python3.7/dist-packages/grimoire_elk/enriched/enrich.py", line 98, in decorator
    eitem = func(self, *args, **kwargs)
  File "/usr/local/lib/python3.7/dist-packages/grimoire_elk/enriched/gitter.py", line 121, in get_rich_item
    eitem.update(self.get_rich_links(item['data']))
  File "/usr/local/lib/python3.7/dist-packages/grimoire_elk/enriched/gitter.py", line 152, in get_rich_links
    url_parsed = urlparse(url['url'])
  File "/usr/lib/python3.7/urllib/parse.py", line 368, in urlparse
    splitresult = urlsplit(url, scheme, allow_fragments)
  File "/usr/lib/python3.7/urllib/parse.py", line 435, in urlsplit
    raise ValueError("Invalid IPv6 URL")
ValueError: Invalid IPv6 URL

It seems like the URLs provided by the API (https://developer.gitter.im/docs/messages-resource) might not be parseable. So better error handling needs to be done?