Closed shanchenqi closed 2 years ago
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
/home/runner/work/grimoirelab-elk/grimoirelab-elk/grimoire_elk/utils.py | 40 | 68.89% | ||
<!-- | Total: | 40 | --> |
Totals | |
---|---|
Change from base Build 2555428948: | -0.02% |
Covered Lines: | 8842 |
Relevant Lines: | 10735 |
Hi, @sduenas, Thank you for your code review. I have updated my pull request according to your advice.
Excuse me, I force to push the commits again in order to squash the commits into one.
LGTM but, would you mind to change the message of the commit? Follow the guidelines I mentioned before (you can also use part of the text included in the changelog entry). Thanks!
OK, I got it and updated the code. Thank you~
@shanchenqi last thing, I realized the PR doesn't contain the latest changes of the repo history. Would you mind to rebase it with master before I merge it?
@shanchenqi last thing, I realized the PR doesn't contain the latest changes of the repo history. Would you mind to rebase it with master before I merge it?
HI, @sduenas , I have rebased the commit messages and all checks passed. Thanks for your help and your affirmation.
@shanchenqi thanks for the PR!
@shanchenqi thanks for the PR!
It's my pleasure!
As we have discussed in Issue #496, we implemented grimoirelab-elk-gitee as a plugin. In order to support this plugin solution, we need to use entry points as I created in this pull request.