Closed Rafaeltheraven closed 1 year ago
Thanks for your patch. Could you rebase the PR (cause the tests are failing) and squash the commits?
I also see some unrelated code to the PR inside the .github/workflows
directory.
Thank you
My apologies, the project for which these fixes were originally made ended so I got distracted, I've cleaned up the PR now and squashed everything into 1 commit.
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
/home/runner/work/grimoirelab-elk/grimoirelab-elk/grimoire_elk/enriched/study_ceres_onion.py | 3 | 88.46% | ||
/home/runner/work/grimoirelab-elk/grimoirelab-elk/grimoire_elk/enriched/study_ceres_aoc.py | 5 | 91.57% | ||
/home/runner/work/grimoirelab-elk/grimoirelab-elk/grimoire_elk/elastic.py | 9 | 90.03% | ||
/home/runner/work/grimoirelab-elk/grimoirelab-elk/grimoire_elk/enriched/enrich.py | 44 | 74.3% | ||
/home/runner/work/grimoirelab-elk/grimoirelab-elk/grimoire_elk/enriched/git.py | 55 | 72.44% | ||
<!-- | Total: | 116 | --> |
Totals | |
---|---|
Change from base Build 4417143000: | 0.02% |
Covered Lines: | 9116 |
Relevant Lines: | 11074 |
LGTM
Can you please add a changelog like in the other pull request?
Hi @Rafaeltheraven could you rebase your branch and I will proceed to merge this PR
Thank you very much for your contribution
The way support for ES 7.X and OS 1.X was originally implemented meant that any major version that was not EXACTLY 7/1 would revert to old behavior. This is obviously wrong and simply changing this check to allow versions >= 7/1 seems to just work (at least in the context of using mordred to import git data from perceval).
I can not guarantee that everything works, and I know that at least kibash still needs some work as discussed here. But in any case, the check was wrong, and this PR should at least fix that.
:edit: Recreated this PR as I messed up what branch I used as the source for this PR and the old one got unclean.