chaoss / grimoirelab-elk

GNU General Public License v3.0
58 stars 121 forks source link

[enrich] Include SortingHat parameters #1095

Closed jjmerchante closed 1 year ago

jjmerchante commented 1 year ago

This PR includes sh_port, sh_path, sh_ssl parameters to all the backends. These parameters are now mandatory in the configuration.

Tests updated accordingly.

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 3893345812


Files with Coverage Reduction New Missed Lines %
/home/runner/work/grimoirelab-elk/grimoirelab-elk/grimoire_elk/enriched/enrich.py 1 74.3%
/home/runner/work/grimoirelab-elk/grimoirelab-elk/grimoire_elk/enriched/dockerdeps.py 3 86.21%
/home/runner/work/grimoirelab-elk/grimoirelab-elk/grimoire_elk/enriched/gitter.py 3 94.05%
/home/runner/work/grimoirelab-elk/grimoirelab-elk/grimoire_elk/enriched/dockersmells.py 5 82.26%
/home/runner/work/grimoirelab-elk/grimoirelab-elk/grimoire_elk/enriched/gerrit.py 5 98.43%
/home/runner/work/grimoirelab-elk/grimoirelab-elk/grimoire_elk/enriched/cocom.py 9 91.95%
/home/runner/work/grimoirelab-elk/grimoirelab-elk/grimoire_elk/enriched/colic.py 9 91.57%
/home/runner/work/grimoirelab-elk/grimoirelab-elk/grimoire_elk/enriched/gitlab.py 12 87.55%
/home/runner/work/grimoirelab-elk/grimoirelab-elk/grimoire_elk/enriched/mattermost.py 13 81.75%
/home/runner/work/grimoirelab-elk/grimoirelab-elk/grimoire_elk/enriched/mbox.py 14 75.0%
<!-- Total: 410 -->
Totals Coverage Status
Change from base Build 3882649759: 0.0%
Covered Lines: 9101
Relevant Lines: 11057

💛 - Coveralls
jjmerchante commented 1 year ago

I saw what you mentioned about the problem with the exception. I suggest to remove that piece of code and add a new PR with that change, because it's not related or include it in a new commit and change the desc of the PR.

I moved that piece of code here: https://github.com/chaoss/grimoirelab-elk/pull/1096