chaoss / grimoirelab-elk

GNU General Public License v3.0
59 stars 120 forks source link

Update graal.py to make it compatible with non-public repos #1114

Closed GrayStranger closed 11 months ago

GrayStranger commented 1 year ago

Anonymize raw origin and tag url to make it more universal for cocom\colic etc. backends and to make it compatible with non-public repos.

GrayStranger commented 1 year ago

Thanks for the fix. Apparently now there are some format errors:

Run poetry run flake8
./grimoire_elk/raw/graal.py:20:2: W291 trailing whitespace
./grimoire_elk/raw/graal.py:27:1: E302 expected 2 blank lines, found 1
./grimoire_elk/raw/graal.py:70:1: W293 blank line contains whitespace
Error: Process completed with exit code 1.

fixed

sorry, i have no a lot of experience with GitHub contributing :). Hope now it should works.

GrayStranger commented 1 year ago

The PR looks good to me. Before we merge it, would you mind to squash all commits into one? If you can't do it, I can do it myself.

Btw, test are failing because the last version of poetry doesn't support Python 3.7. We're fixing it.

done

GrayStranger commented 1 year ago

fixed signature in commit after sqashing

GrayStranger commented 1 year ago

@sduenas I think now its all good to let it in, right? :)

sorry for ping.

sduenas commented 1 year ago

@sduenas I think now its all good to let it in, right? :)

sorry for ping.

There's still some style errors:

./grimoire_elk/raw/graal.py:72:1: W293 blank line contains whitespace Error: Process completed with exit code 1.

GrayStranger commented 1 year ago

whitespaces removed

GrayStranger commented 1 year ago

could you please advice me - how can I perform such checks by myself?

sduenas commented 1 year ago

could you please advice me - how can I perform such checks by myself?

If you do an online editing of the file I don't really know, but you can always download the file and run the python tool "flake8". The tests use this tool to see if it complies with the PEP8 specification (it's a guide of style for Python).

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 6468834462


Totals Coverage Status
Change from base Build 6467374446: 0.003%
Covered Lines: 7489
Relevant Lines: 8754

💛 - Coveralls
GrayStranger commented 12 months ago

@sduenas just friendly reminder to merge it for the next release :)

sduenas commented 11 months ago

@GrayStranger merged.

I updated your branch to include a changelog file that we use for automating realeases and for rebasing to the latest commit. I hope you don't mind.

Thanks for your contribution.