chaoss / grimoirelab-elk

GNU General Public License v3.0
58 stars 121 forks source link

[enrich] Arguments in wrong order in some backends #1122

Closed jjmerchante closed 8 months ago

jjmerchante commented 8 months ago

This PR resolves a bug where the arguments in the __init__ method of certain enrich backends were incorrectly ordered, or missing.

The original signature of the Enrich backend is:

def __init__(self, db_sortinghat=None, json_projects_map=None, db_user='',
             db_password='', db_host='', insecure=True, db_port=None, db_path=None,
             db_ssl=False, db_verify_ssl=True, db_tenant=None):

But the backends that overwrite that method had this signature:

def __init__(self, db_sortinghat=None, json_projects_map=None, db_user='',
             db_password='', db_host='', db_path=None, db_port=None,
             db_ssl=False, db_verify_ssl=True, db_tenant=None):

This change requires another change in sirmordred.

coveralls commented 8 months ago

Pull Request Test Coverage Report for Build 6558778259


Totals Coverage Status
Change from base Build 6510219185: 0.0%
Covered Lines: 7489
Relevant Lines: 8754

💛 - Coveralls