chaoss / grimoirelab-elk

GNU General Public License v3.0
59 stars 120 forks source link

[qm-elk] Add support for QM data enrichment #902

Closed vchrombie closed 4 years ago

vchrombie commented 4 years ago

This PR contains gitlabqm and gitqm enrichers.

metrics discussion for gitqm: https://github.com/vchrombie/gsoc/issues/9 output example for gitqm: gist-file-gitqm

micro-mordred configurations

project.json

{
    "potioncraft" : {
        "gitqm": [
            "https://github.com/vchrombie/gsoc.git"
        ],
        "gitlabqm:issue": [
            "https://gitlab.com/amfoss/cms-mobile"
        ],
        "gitlabqm:merge": [
            "https://gitlab.com/amfoss/cms-mobile"
        ]
    }
}

setup.cfg

[gitqm]
raw_index = gitqm_raw
enriched_index = gitqm
category = commit

[gitlabqm:issue]
api-token = xxxx
raw_index = gitlabqm-issues_raw
enriched_index = gitlabqm
sleep-for-rate = true
category = issue
no-archive = true

[gitlabqm:merge]
api-token = xxxx
raw_index = gitlabqm-merge_raw
enriched_index = gitlabqm
sleep-for-rate = true
category = merge_request
no-archive = true
coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 2314


Files with Coverage Reduction New Missed Lines %
/home/travis/build/chaoss/grimoirelab-elk/grimoire_elk/utils.py 36 66.42%
<!-- Total: 36 -->
Totals Coverage Status
Change from base Build 2313: -1.5%
Covered Lines: 8368
Relevant Lines: 10374

💛 - Coveralls
vchrombie commented 4 years ago

Hi @valeriocos Thanks for the review. I have checked the comments. I have faced such issues while implementing the pipermailqm enricher. I fixed it. Updating the normalizing date function will fix most of the things.

EDIT: I forgot to add one of the things we discussed in the last GSoC meeting. The QM enrichers should go to a specific module, as similarly done for the SCMS ones. On the other hand, the tests for the QM enrichers don't need to be separated from the rest.

Sure, I will implement all these things and produce the next PR as an extension of this PR soon.

vchrombie commented 4 years ago

closing this PR, in reference to https://github.com/chaoss/grimoirelab-elk/pull/926