chaoss / grimoirelab-elk

GNU General Public License v3.0
59 stars 120 forks source link

[JIRA] Fix for p2o enrich data fails when jira user is anonymous #932

Closed teragopher closed 4 years ago

teragopher commented 4 years ago

Fix for https://github.com/chaoss/grimoirelab-elk/issues/931

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 2387


Files with Coverage Reduction New Missed Lines %
/home/travis/build/chaoss/grimoirelab-elk/grimoire_elk/enriched/jira.py 17 91.01%
<!-- Total: 17 -->
Totals Coverage Status
Change from base Build 2384: 0.0%
Covered Lines: 8347
Relevant Lines: 10160

💛 - Coveralls
teragopher commented 4 years ago

Hi @vchrombie , just checking if there is any other thing to do. If not we can go ahead and merge, yes? :)

vchrombie commented 4 years ago

Hi @vchrombie , just checking if there is any other thing to do. If not we can go ahead and merge, yes? :)

Hi @teragopher, thanks for your contribution. The changes look good to me.

I would leave the PR to @sduenas or @zhquan for their review. They will surely get back to you.

teragopher commented 4 years ago

Hi @sduenas @zhquan , Can you please take a look at this and review? :)

sduenas commented 4 years ago

Merged. Thanks for the contribution.