update github_events #951

chaoss / grimoirelab-elk

GNU General Public License v3.0

59 stars 121 forks source link

update github_events #951 #963

Closed rohanreddych closed 3 years ago

rohanreddych commented 3 years ago

Signed-off-by: rohan reddy rohan.ch.reddy@gmail.com

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 675550649

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 82.243%

Totals
Change from base Build 662061987:	0.02%
Covered Lines:	8610
Relevant Lines:	10469

💛 - Coveralls

rohanreddych commented 3 years ago

@sduenas i think you can merge this now?

rohanreddych commented 3 years ago

@sduenas can you merge this ?

rohanreddych commented 3 years ago

The commit message is wrong. It should be:

[schema] Fix missing values in github event schema.

Aggregatable column didn't have a boolean value.

This commit resolves #951

Will follow this format in the future.

sduenas commented 3 years ago

The commit message is wrong. It should be:
[schema] Fix missing values in github event schema.

Aggregatable column didn't have a boolean value.

This commit resolves #951
Will follow this format in the future.

Thanks. I also made a mistake with the format because I was cutting and pasting. The title of the commit doesn't have a period. For this time is ok.

sduenas commented 3 years ago

Merged.