chaoss / grimoirelab-elk

GNU General Public License v3.0
59 stars 121 forks source link

[enriched/mattermost] Improve fields #982

Closed zhquan closed 3 years ago

zhquan commented 3 years ago

This change includes useful fields:

Remove obsolete fields:

Schema update accordingly.

Signed-off-by: Quan Zhou quan@bitergia.com

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 864274243


Files with Coverage Reduction New Missed Lines %
/home/runner/work/grimoirelab-elk/grimoirelab-elk/grimoire_elk/enriched/mattermost.py 16 80.33%
<!-- Total: 16 -->
Totals Coverage Status
Change from base Build 864260899: 0.09%
Covered Lines: 8636
Relevant Lines: 10483

💛 - Coveralls
ajaragz commented 3 years ago

Tested with a local docker Mattermost instance https://docs.mattermost.com/install/docker-local-machine.html. From a channel with multiple posts and reactions.

All fields added were found in the enriched documents. None of the removed fields are in the enriched documents.

Regarding new fields that may be interesting I don't see much else. I see that there's no email in the enriched fields but with the user_data_name and user_data_domain that's coevered.

LGTM