chaoss / grimoirelab-elk

GNU General Public License v3.0
59 stars 121 forks source link

[schema] Update Kafka KIP schema #983

Closed canasdiaz closed 3 years ago

canasdiaz commented 3 years ago

This patch extends the information schema we have for Kafka KIP following the standard format which includes the fields "name", "type", "aggregatable" and "description" for every field in the enriched index.

Signed-off-by: Luis Cañas-Díaz lcanas@bitergia.com

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 935523662


Totals Coverage Status
Change from base Build 922111005: 0.02%
Covered Lines: 8667
Relevant Lines: 10537

💛 - Coveralls
zhquan commented 3 years ago

@sanacl I miss these fields:

And where does the repository_labels field come from?

canasdiaz commented 3 years ago

@zhquan oh, good catch! you are right about the missing fields.

You can see the code which assign the repository_labels at:

canasdiaz commented 3 years ago

@zhquan it is "fun" that the repository_labels field is not visible from the index pattern menu but it is from the discover app. I guess this is because of the two different indexes that are linked by the alias (mbox and pipermail indexes)

zhquan commented 3 years ago

@sanacl ok, then we have to update the index pattern to include repository_labels

canasdiaz commented 3 years ago

@zhquan should I add to the documentation all the fields visible from the discovery app? I guess the answer is yes, right?

canasdiaz commented 3 years ago

Hey @zhquan, I compared the fields we have both in the index pattern and the ones visible from the discover app. The ones below were not added as they are undefined and I do not find documentation about them:

I think they should not be part of this patch.


UPDATE: I've also excluded From_gender and From_gender_acc because of the same reason.

zhquan commented 3 years ago

@sanacl I see that the following fields are in the index pattern:

Undefined fields (there may be more):

We have two options:

  1. In this PR update only the available fields on the index pattern. And update again when the index pattern is updated
  2. First update the index pattern and then update all fields in this PR
canasdiaz commented 3 years ago

@zhquan in order to avoid being blocked and start "delivering" something I've done what you suggested in option 1. I've only included the ones available in the index pattern.

zhquan commented 3 years ago

@sanacl rebase it and I will merge it thanks.

canasdiaz commented 3 years ago

@zhquan done