chaoss / grimoirelab-elk

GNU General Public License v3.0
59 stars 121 forks source link

[gitlab] Autodetect gitlab enterprise-url arg #995

Closed Alch-Emi closed 3 years ago

Alch-Emi commented 3 years ago

The enterprise-url parameter of the gitlab backend is currently left to be specified by the user in the config file. This commit removes this burden from the user by automatically detecting the enterprise URL from the url passed to get_perceval_params_from_url()`.

This aims to make it easier for users to work with enterprise GitLab instances by removing the need to use the enterprise-url at all.

As far as I know, this does not introduce any backwards-compatibility issues.

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 1121968729


Files with Coverage Reduction New Missed Lines %
/home/runner/work/grimoirelab-elk/grimoirelab-elk/grimoire_elk/raw/gitlab.py 2 84.62%
<!-- Total: 2 -->
Totals Coverage Status
Change from base Build 1052244504: -0.02%
Covered Lines: 8667
Relevant Lines: 10539

💛 - Coveralls