search

chaoss / grimoirelab-graal

A Generic Repository AnALyzer
GNU General Public License v3.0
21 stars 62 forks source link

Fix some stuff to have a reasonable pip package #1

Closed jgbarah closed 5 years ago

jgbarah commented 6 years ago

Import grimoirelab_toolkit instead of grimoirelab.toolkit. Some documentation on installing cloc. Version back to 0.1.0, reserving for future improvements.

I already uploaded a package to pypi with these changes, so please accept them ;-)

jgbarah commented 5 years ago

@valeriocos I don't know if this still makes sense, or maybe you already added these changes yourself... Please, have a look, since this should be fixed for including Graal in the next GrimoireLab release...

valeriocos commented 5 years ago

Sorry for the late reply @jgbarah , I didn't see your PR. The changes in graal/graal.py have been already included in the code base, the remaining ones are not. If you want to fix the conflicts in your PR, I'll merge it (sorry for the inconvenience).

valeriocos commented 5 years ago

ping @jgbarah , let me know how you want to proceed

jgbarah commented 5 years ago

I saw most of the patch is already in, so I just left the changes to README.md, which I think are still appropriate.

jgbarah commented 5 years ago

Oooops. I just realized the little change I was proposing in the README file is already in a different section of it. So, this patch is no longer needed. Sorry for the noise.