search

chaoss / grimoirelab-graal

A Generic Repository AnALyzer
GNU General Public License v3.0
21 stars 62 forks source link

[backend] Add backend analyzer options to help message #25

Closed inishchith closed 5 years ago

inishchith commented 5 years ago

Addresses #24

@valeriocos Please review and let me know if any changes required

Thanks

inishchith commented 5 years ago

@valeriocos Sorry for the delayed response.

I have also a question for you :) I see that for all test_setup_cmd_parser you didn't use the default from_date value as done in the perceval backends tests (e.g., https://github.com/chaoss/grimoirelab-perceval/blob/master/tests/test_git.py#L826), why ?

I checked for existing implementation of test_setup_cmd_parser and found that it had used str_to_datetime for some reason and thought to go ahead with it. Now after you raised this, i feel it's better to keep both the components in sync with DEFAULT_DATETIME. Let me know what you think, I'll make sure to update with changes :)

valeriocos commented 5 years ago

Thank you for answering @inishchith . I'm fine with any decision you take (my question was just a curiosity) :)

inishchith commented 5 years ago

@valeriocos I've made the necessary changes. Please let me know if any more changes required :)