Closed inishchith closed 5 years ago
Thank you for addressing the comments @inishchith
@valeriocos I've updated the PR.
I've made the changes wrt. the assumption that exec_path
provided would always point to the scancode
executable. Please let me know if we're keeping it as the default convention of usage.
Thanks
Sorry for the late reply @inishchith .
To avoid confusion It is probably better if exec_path
points to the file that should be executed (either scancode
or scancli.py). Why
exec_pathshould always point to
scancode` ?
@valeriocos This came to my mind as I referred your implementation here and thought if we were planning to do so, now i understand that it was for a quick test. Thanks for the clarification. I'll make the changes
perfect, thanks! That branch was a quick test, PR #28 should be better :)
@valeriocos I've made the changes. Please do have a look I moving ahead to working on tests :)
Great @inishchith , thank you for the updates. Please ping when the tests are ready! :)
@valeriocos I had a thought before starting work on tests.
We are required to accommodate configuring scancli.py
before the tests start. So, I was thinking to perform
git checkout -b xxx 8afa686fb71b9540029234e5a40c0572c4457c28
above checkout commit and 1st
and 2nd
step from this doc in build under before_script
under travisci configuration.
Edit: I think we have to use a clone instead of a release as the latest release of scancode-toolkit
was on 15th Feb, and scancli
was added later ( 5th march ).
I didn't realize that I tested my work on a clone, instead of v3.0.0
.
Please let me know what you think :)
@valeriocos I'm not sure why there's no travis-ci
and coverage
triggered on last push.
Can you please check?
Edit: It took some more time to start 🙈
@valeriocos Please review when you get time Thanks :)
Note:
scancode
. hence had to find a later commit.Edit:
I'm on it @inishchith :)
@valeriocos I've gone through the comments and I see there are improvements needed. I'll work on them and update you accordingly :)
Thanks
Great! Thank you @inishchith to check the comments
@valeriocos I've worked on the requested changes.
1
& 3
into 1
, made the requested changes and updated commit description.2nd
commit (travis.yml)README
Please let me know if I've missed something
Thanks
@valeriocos Please do have a look when you get time :) Thanks
@valeriocos Thanks for the review I've updated the doc-string, please do have a look :)
Addresses: #27
@valeriocos In reference to your PR. This contains some minor changes. Still, there are some improvements which can be made and tests should be added accordingly. Please do have a look, Thanks :)
Work attributions: @valeriocos 's #28