search

chaoss / grimoirelab-graal

A Generic Repository AnALyzer
GNU General Public License v3.0
21 stars 62 forks source link

[cocom] Evaluating results with repository level analysis #36

Closed inishchith closed 5 years ago

inishchith commented 5 years ago

issue triggered in discussion of inishchith/gsoc-graal#6

valeriocos commented 5 years ago

Would this option imply to execute the analysis at repository level for each commit? If so, the analysis for large repositories may be problematic.

inishchith commented 5 years ago

@valeriocos Yes, had the thought and thanks for pointing it out!. I've had a look at Lizard's Usage and would like to evaluate it. Let me know what you think

I would be trying some improvements along, will update you how it goes.

Edit: I also have a rough idea in mind which is related to enriching the results over time using global storage. I'll probably have more clarity once I've worked on it. Thanks!

inishchith commented 5 years ago

@valeriocos

I've tried to implement the repository level analysis. Below is the comparison.

Repository Number of Commits *File Level Repository Level
coala/coala 4458 58.89 min 59.92 min
[chaoss/grimoirelab-perceval]() 1387 24.83 min 26.63 min
[chaoss/grimoirelab-graal]() 169 1.82 min 1.86 min

* represents current in-place method

I feel this would be good-to-have option in Graal and as I've mentioned in https://github.com/inishchith/gsoc-graal/issues/6#issuecomment-501297676, would make it easier to visualize the data in Kibana. I'm yet to discover an edge case in the implementation. If you agree, i could draft the rough idea ( in a PR ) and we can then review the idea. Let me know what you think.

valeriocos commented 5 years ago

yes sure @inishchith , feel free to submit a PR and we can discuss there, thanks!