[tests] Fix failing tests

chaoss / grimoirelab-graal

A Generic Repository AnALyzer

GNU General Public License v3.0

21 stars 62 forks source link

[tests] Fix failing tests #4

Closed inishchith closed 5 years ago

inishchith commented 5 years ago

[x] fix links in test files for NOMOS and SCANCODE
[x] fix badge links in readme
[x] fix .travis.yml for storing executables from scancode and fossology/nomos
[x] All test passed

@valeriocos Please review and let me know if any changes required 😄

Note: Reference. There's 1 test which still fails due to bad JSON at this line.

closes #3

valeriocos commented 5 years ago

@inishchith thank you a lot for the PR. I cannot test it today, but I'll do it tomorrow.

inishchith commented 5 years ago

@valeriocos Sure, No problem. Though i had a concern, I need some suggestion in fixing the last test issue here . I think it's due to bad JSON return.

valeriocos commented 5 years ago

Thank @inishchith for the PR, overall LGTM, I left some minor comments. WRT the failing test, I don't detect the problem locally when installing the release 3.0.0 of scancode, instead the error pops up when cloning the repo. Please try to change the .travis.yml to install that version of scancode.

inishchith commented 5 years ago

@valeriocos Thanks for reviewing the PR ;)

[x] I've added the PATH in utils.py
[x] I did try version v3.0.0 and v2.9.2 after your suggestion, but the results are same.
- Ref v3.0.0
- Ref v2.9.2

valeriocos commented 5 years ago

no worries, I would merge the PR anyway and take a closer look later.

If you agree, could you reorganize the commits in the following way, adding also msgs and descrs:

1 commit including the modifications in the tests folder -> [tests] ...
1 commit for the changes in README.md and setup.py -> [doc] ...
1 commits for the changes in .travis.yml -> [travis] ...

thank you @inishchith

inishchith commented 5 years ago

@valeriocos Thanks for the review. That looks like a great convention to follow. I've made the changes. Let me know if any changes required 😄 . Also please do let me know once you take a closer look on the issue, even i'll try and fix it ASAP ;)

valeriocos commented 5 years ago

@inishchith overall the PR looks great, I've left just some minor comments. Thank you for your time.

inishchith commented 5 years ago

@valeriocos Thanks for all the help. The tests pass completely now 😅

valeriocos commented 5 years ago

Thank you a lot @inishchith for the PR, I have just merged it (I don't know why it looks like it wasn't merged).

inishchith commented 5 years ago

@valeriocos Thanks for the merge 😄 . I'm waiting of the Build Passing 🎉 to appear on the Repository Readme 😛