chaoss / grimoirelab-hatstall

GNU General Public License v3.0
8 stars 18 forks source link

Control date overlapping in different enrollments #82

Open mafesan opened 5 years ago

mafesan commented 5 years ago

When two or more enrollments are added to a given profile, Hatstall should prevent or at least warn about overlapped start or end dates. I think it is logical that neither start or ending dates from the different enrollments overlap. Besides, this can cause that the affiliation data will not be properly updated in GrimoireLab dashboards.

For instance, let's imagine there is a profile with two enrollments:

With those values, Hatstall should control that there is an overlapping on 2017-03-25 and ask the user to change one of the two dates, to one day after or one day before that date (For instance, the start date for the second company would be 2017-03-26).

canasdiaz commented 4 years ago

One of our customers of the Bitergia Analytics platform has suggested the same feature.

aindermitte commented 4 years ago

Please implement some kind of intelligent solution here that tries to recommend correct dates. I.e., if you see that suddenly contributions from IBM stop and MS start, you know that this is roughly the date of the move.

Another option is to look at where the latest contributions came in, an propose this as "primary" organization. In many cases, we have no idea when a person moved from one organization to another; in these cases it is better to err on the "latest" organization.

The current behavior, explained to me as "we don't know what happens when two or more organizations overlap" is, frankly, unacceptable.