chaoss / grimoirelab-kibiter

Soft fork of Kibana, for the benefit of GrimoireLab
https://chaoss.github.io/grimoirelab
Other
24 stars 17 forks source link

Menu UI bug - not showing sub-menu items where there's a single item until expanding other menu items #119

Closed RCheesley closed 5 years ago

RCheesley commented 5 years ago

Kibana version: Version: 6.1.4-1

Browser version: Chrome

Browser OS version: 77.0.3865.90 (Official Build) (64-bit)

Original install method (e.g. download page, yum, from source, etc.): Installed GrimoireLab via Docker using the Mac install instructions.

Description of the problem including expected versus actual behavior: When there is a menu item with only one item (in my case, Slack and Discourse), the sub-menu items do not appear on the first activation of the menu. I have to hover over one of the other menu items (e.g. git, github) and activate the sub-menu before I can see the link to the overview link.

Steps to reproduce: See screen cast here: https://youtu.be/24wTj7SaqdM where I'm demonstrating it a couple of times.

dlumbrer commented 5 years ago

Hi @RCheesley ,

The Kibana/Kibiter version is outdated. Please, can you test the behavior using the latest Kibiter tag (optimized-v6.1.4-4)?

Thanks

RCheesley commented 5 years ago

Thanks @dlumbrer, I followed the installation instructions provided in the guide here: https://github.com/chaoss/website/pull/230 which pulls from this repo: https://gitlab.com/Bitergia/lab/analytics-demo - I think I should be running the correct version according to my docker-compose file.

I checked the version here: screenshot-159 203 179 82_5601-2019 10 09-10_29_35

Maybe the wrong place/wrong information?

I just pulled from the analytics demo repo and restarted my containers to double check I was up to date, but still this bug remains.

dlumbrer commented 5 years ago

Thanks @dlumbrer, I followed the installation instructions provided in the guide here: chaoss/website#230 which pulls from this repo: https://gitlab.com/Bitergia/lab/analytics-demo - I think I should be running the correct version according to my docker-compose file.

I checked the version here: screenshot-159 203 179 82_5601-2019 10 09-10_29_35

Maybe the wrong place/wrong information?

I just pulled from the analytics demo repo and restarted my containers to double check I was up to date, but still this bug remains.

Could you confirm that in the docker-compose that you are using the tag of Kibiter is this one: bitergia/kibiter:optimized-v6.1.4-4?

Thanks!

RCheesley commented 5 years ago

kibiter: restart: on-failure:5 image: bitergia/kibiter:optimized-v6.1.4-4

dlumbrer commented 5 years ago

kibiter: restart: on-failure:5 image: bitergia/kibiter:optimized-v6.1.4-4

Thank you!

I'm going to test it and reach a solution ASAP

dlumbrer commented 5 years ago

HI @RCheesley,

We have studied and tried to replicate the problem with the latest version (bitergia/kibiter:optimized-v6.1.4-4) and we didn't see the issue with the menu.

However, we tried the version that you used first (bitergia/kibiter:optimized-v6.1.4-1) and the issue appears, we noticed that and solved it (https://github.com/chaoss/grimoirelab-kibiter/pull/104).

So, I was wondering if maybe the containers didn't update well and are still using the old version.

Could you check if the old kibiter container was correctly deleted and the new one (with the latest tag) has been deployed?

RCheesley commented 5 years ago

Sure, how would I go about trying to do that?

On Wed, 16 Oct 2019, 14:05 David Moreno Lumbreras, notifications@github.com wrote:

HI @RCheesley https://github.com/RCheesley,

We have studied and tried to replicate the problem with the latest version (bitergia/kibiter:optimized-v6.1.4-4) and we didn't see the issue with the menu.

However, we tried the version that you used first ( bitergia/kibiter:optimized-v6.1.4-1) and the issue appears, we noticed that and solved it (#104 https://github.com/chaoss/grimoirelab-kibiter/pull/104).

So, I was wondering if maybe the containers didn't update well and are still using the old version.

Could you check if the old kibiter container was correctly deleted and the new one (with the latest tag) has been deployed?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/chaoss/grimoirelab-kibiter/issues/119?email_source=notifications&email_token=AAWLPILGJMTH5AR7KUB27JTQO4GP3A5CNFSM4I6SWP32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBMMXNY#issuecomment-542690231, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAWLPII3W2PXZ6EATXF6YD3QO4GP3ANCNFSM4I6SWP3Q .

dlumbrer commented 5 years ago

Sure, how would I go about trying to do that? On Wed, 16 Oct 2019, 14:05 David Moreno Lumbreras, @.***> wrote: HI @RCheesley https://github.com/RCheesley, We have studied and tried to replicate the problem with the latest version (bitergia/kibiter:optimized-v6.1.4-4) and we didn't see the issue with the menu. However, we tried the version that you used first ( bitergia/kibiter:optimized-v6.1.4-1) and the issue appears, we noticed that and solved it (#104 <#104>). So, I was wondering if maybe the containers didn't update well and are still using the old version. Could you check if the old kibiter container was correctly deleted and the new one (with the latest tag) has been deployed? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#119?email_source=notifications&email_token=AAWLPILGJMTH5AR7KUB27JTQO4GP3A5CNFSM4I6SWP32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBMMXNY#issuecomment-542690231>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAWLPII3W2PXZ6EATXF6YD3QO4GP3ANCNFSM4I6SWP3Q .

I think that the best way to do this is to delete the container of the old kibiter and launch the new one once the old one has been stopped and deleted correctly?

Something like:

docker-compose -f <compose_yml_file> stop kibiter
docker-compose -f <compose_yml_file> rm kibiter

# Make sure that the docker-compose yml file contains the latest version of Kibiter (optimized-v6.1.4-4)

docker-compose -f <compose_yml_file> pull kibiter
docker-compose -f <compose_yml_file> up kibiter -d
dlumbrer commented 5 years ago

Hi @RCheesley ,

Since we didn't find any issue with the latest release, we are going to close this issue. Please, reopen it if you find any problem.

Thanks