search

chaoss / grimoirelab-kibiter

Soft fork of Kibana, for the benefit of GrimoireLab
https://chaoss.github.io/grimoirelab
Other
24 stars 17 forks source link

Bitergia logo does not load #144

Closed sduenas closed 4 years ago

sduenas commented 4 years ago

This bug is related with the code in secured-v6.8.6-2 tag and others related to it.

When the env variable LOGIN_BRANDIMAGE is not set, the container should load the Bitergia logo (see it in here).

The link to the image is down. Due to this and empty image is loaded when loading the login page.

imagen

dlumbrer commented 4 years ago

As @sduenas said, this error appears when the link to the asset in the web-page is down. In order to solve this, we added the image in the repository in order to have always the image there.

I prepared the PR (#145), please @sduenas, check it when you can

jsmanrique commented 4 years ago

One small comment. I think Kibiter should have 2 look & feels or skins (including this logo):

dlumbrer commented 4 years ago

One small comment. I think Kibiter should have 2 look & feels or skins (including this logo):

* one for GrimoireLab (as part of the GrimoireLab toolkit)

* one for Bitergia Analytics (as part of the Bitergia Analytics platform)

It has two versions indeed, as we have integration-6.8.6 (Bitergia) and integration-community-6.8.6 (GrimoireLab). Moreover, in the releases tab, we have the binaries of each version there (ready to download and launch) :smile: .

This logo is for the login form, the community version does not have the security plugin installed, that's the reason for doing the PR just on one branch.

dlumbrer commented 4 years ago

Image created and issue solved, closing!