chaoss / grimoirelab-kibiter

Soft fork of Kibana, for the benefit of GrimoireLab
https://chaoss.github.io/grimoirelab
Other
24 stars 17 forks source link

Kibiter crashes due to JS syntax error #40

Open canasdiaz opened 6 years ago

canasdiaz commented 6 years ago

Kibana version: 5.1.1

Elasticsearch version: 5.1.1

Server OS version: NA

Browser version: Chromium 60.0.3112.78

Browser OS version: NA

Original install method (e.g. download page, yum, from source, etc.): NA

Description of the problem including expected versus actual behavior: Kibiter does not server any content but an Internal Server Error

Steps to reproduce:

  1. Go to Kibiter's URL
  2. Look at your screen

Provide logs and/or server output (if relevant):

{  
   "type":"error",
   "@timestamp":"2017-11-15T13:13:41Z",
   "tags":[  

   ],
   "pid":1,
   "level":"error",
   "message":"/opt/kibana/src/ui/views/chrome.jade:12\n    10|     meta(http-equiv='X-UA-Compatible', content='IE=edge,chrome=1')\n    11|     meta(name='viewport', content='width=device-width')\n  > 12|     meta(name='description', content='Bitergia analytics for 'Mozilla' provided by Bitergia using GrimoireLab Open Source technology')\n    13|     title Bitergia Analytics\n    14|     style.\n    15|       @font-face {\n\nUnexpected identifier",
   "error":{  
      "message":"/opt/kibana/src/ui/views/chrome.jade:12\n    10|     meta(http-equiv='X-UA-Compatible', content='IE=edge,chrome=1')\n    11|     meta(name='viewport', content='width=device-width')\n  > 12|     meta(name='description', content='Bitergia analytics for 'Mozilla' provided by Bitergia using GrimoireLab Open Source technology')\n    13|     title Bitergia Analytics\n    14|     style.\n    15|       @font-face {\n\nUnexpected identifier",
      "name":"SyntaxError",
      "stack":"SyntaxError: /opt/kibana/src/ui/views/chrome.jade:12\n    10|     meta(http-equiv='X-UA-Compatible', content='IE=edge,chrome=1')\n    11|     meta(name='viewport', content='width=device-width')\n  > 12|     meta(name='description', content='Bitergia analytics for 'Mozilla' provided by Bitergia using GrimoireLab Open Source technology')\n    13|     title Bitergia Analytics\n    14|     style.\n    15|       @font-face {\n\nUnexpected identifier\n    at assertExpression (/opt/kibana/node_modules/jade/lib/lexer.js:30:3)\n    at Object.attrs (/opt/kibana/node_modules/jade/lib/lexer.js:676:20)\n    at Object.next (/opt/kibana/node_modules/jade/lib/lexer.js:939:15)\n    at Object.lookahead (/opt/kibana/node_modules/jade/lib/lexer.js:113:46)\n    at Parser.lookahead (/opt/kibana/node_modules/jade/lib/parser.js:102:23)\n    at Parser.peek (/opt/kibana/node_modules/jade/lib/parser.js:79:17)\n    at Parser.tag (/opt/kibana/node_modules/jade/lib/parser.js:773:22)\n    at Parser.parseTag (/opt/kibana/node_modules/jade/lib/parser.js:759:17)\n    at Parser.parseExpr (/opt/kibana/node_modules/jade/lib/parser.js:211:21)\n    at Parser.block (/opt/kibana/node_modules/jade/lib/parser.js:729:25)\n    at Parser.tag (/opt/kibana/node_modules/jade/lib/parser.js:838:24)\n    at Parser.parseTag (/opt/kibana/node_modules/jade/lib/parser.js:759:17)\n    at Parser.parseExpr (/opt/kibana/node_modules/jade/lib/parser.js:211:21)\n    at Parser.block (/opt/kibana/node_modules/jade/lib/parser.js:729:25)\n    at Parser.tag (/opt/kibana/node_modules/jade/lib/parser.js:838:24)\n    at Parser.parseTag (/opt/kibana/node_modules/jade/lib/parser.js:759:17)"
   },
   "url":{  
      "protocol":null,
      "slashes":null,
      "auth":null,
      "host":null,
      "port":null,
      "hostname":null,
      "hash":null,
      "search":"",
      "query":{  

      },
      "pathname":"/app/kibana",
      "path":"/app/kibana",
      "href":"/app/kibana"
   }
}
dlumbrer commented 6 years ago

There is a problem with the single quotes ( ' )

I'm going to fix it

canasdiaz commented 6 years ago

Hey @dlumbrer, the current string it is not very well written. Instead of :+1:

dlumbrer commented 6 years ago

Hi @sanacl,

I didn't choose that string. I agree with you but we have to discuss that change with @jsmanrique.

jsmanrique commented 6 years ago

Or even more simple: 'Bitergia Analytics for {{Project}}, powered by GrimoireLab technology'

dlumbrer commented 6 years ago

@jsmanrique, Understood!

I have already talked with @sanacl, I'm going to change it and make the PR!

dlumbrer commented 6 years ago

The new image of kibiter is already built in docker-hub!!