search

chaoss / grimoirelab-perceval

Send Sir Perceval on a quest to retrieve and gather data from software repositories.
http://perceval.readthedocs.io/
GNU General Public License v3.0
290 stars 177 forks source link

Adding deletion for old tag references #845

Closed mjgaughan closed 2 months ago

mjgaughan commented 4 months ago

title: 'Adding deletion for old tag references' category: fixed author: Matt Gaughan mgaughan@proton.me issue: (782)[https://github.com/chaoss/grimoirelab-perceval/issues/782] notes: > If server deletes reference to tag, local repo will as well. Simple implementation for clarity's sake.

mjgaughan commented 4 months ago

@jjmerchante hello! Thank you for your help with sorting out this PR -- when I run_tests.py on my local, there are a handful of errors in unrelated tests. I'm not sure how many of these are a function of the changes that I have made, which I regard as small. Please let me know if I'm breaking something in a way I don't anticipate -- still getting familiar with the broader code base architecture!

sduenas commented 4 months ago

@jjmerchante hello! Thank you for your help with sorting out this PR -- when I run_tests.py on my local, there are a handful of errors in unrelated tests. I'm not sure how many of these are a function of the changes that I have made, which I regard as small. Please let me know if I'm breaking something in a way I don't anticipate -- still getting familiar with the broader code base architecture!

The current errors in the tests are because you aren't following the code style defined by flake8 in your test file.

mjgaughan commented 2 months ago

@vchrombie Thank you for your help with this PR and for the useful suggestions in code review. I have implemented your changes to test as well as added a changelog file. Please let me know if there are any other steps to merging.

vchrombie commented 2 months ago

Hi @mjgaughan, thanks for working on this. As a final step, can you squash all these commits into one? Let me know if you need any help.

mjgaughan commented 2 months ago

Hey @vchrombie I just squashed the commits; let me know if it looks ok! Thanks so much for your help with this

sduenas commented 2 months ago

Can you edit the commit message? It has multiple lines with the signed off trailer and also it doesn't describe what you did on this commit. Please also start the first line with [git] Add deletion of old tag references.

mjgaughan commented 2 months ago

@vchrombie @sduenas Just updated the commit message to meet what I believe is specification. Please let me know if there are any errors. Thanks!