dicortazar
commented
6 years ago Hi there, thanks a lot for this @jsmanrique . This looks great to me.
Some comments for the next panels:
- There's a specific naming for index patterns, visualizations or even the panels. Please in the following try to comply with those: https://github.com/chaoss/grimoirelab-sigils/blob/master/README.md
- Said this, it's ok to work in this way as we do not overwrite previous widgets, but this will take time to us to modify your JSON doc in order to follow the expected naming.
- It seems that you're not following or using an updated version of the Git index as your visualization is looking for a field named as lines_deleted, while the name is lines_removed: https://github.com/chaoss/grimoirelab-elk/blob/master/schema/git.csv#L22
- How did you choose the thresholds for the average number of files and lines for the gauges? It would be good to have some references. Another point would be to let users know about this and that this is configurable, so they can have their own customized number (although having numbers is still a good idea...)
And that's all, we're working right now on this panel.
Thanks!
alpgarcia
jsmanrique
I have created a panel to showcase average files and lines of code changed by commit (total and evolution over time) Thanks to new gauges visualizations in Kibiter 6.x and Timeline, I've put some thresholds that allow to check if they are passed and how the trend evolves:
The panel includes authors and repositories tables to make easy to filter by author and repository.
Here goes the
.jsonfile zipped: jsm_git_perfomance.zipThe panel has been exported with Kidash.
If you find it useful, feel free to add it to the default platform or modify it for your needs