search

chaoss / grimoirelab

GrimoireLab: platform for software development analytics and insights
https://chaoss.github.io/grimoirelab/
GNU General Public License v3.0
500 stars 184 forks source link

Display how many pull requests a contributor accepted and closed #215

Open GeorgLink opened 5 years ago

GeorgLink commented 5 years ago

I would like to know on an individual maintainer level, how many pull requests that contributor accepted and merged or closed without merging.

Maintainer who decided on PR Merged/Accepted PRs Closed/Rejected PRs
Georg 0 42
Adam 12 1
Eve 10 0

Is that data already available in GrimoireLab? If yes, how can the above visualization be built?

jsmanrique commented 5 years ago

Do you mean for each contributor, how many PRs get accepted and rejected? Or for each maintainer or reviewer, whose PRs they have a accepted or rejected and how many?

I'm not sure, but for the 1st question there might be data, but it might be a matter of building a visualization, and maybe a custom index. I think @alpgarcia has more expertise than me on this.

For the second, there might be data, but not 100% sure. I know there has been some work on this gathering data from Github PRs API endpoint.

I'm sure @valeriocos and @alpgarcia have more knowledge about this.

GeorgLink commented 5 years ago

I'm asking about the second. I'll revise the first column to "Maintainer".

How many times has a "maintainer" clicked the "merge" button or "close" button (assuming the pr stays closed). The PR may have been opened by someone else and I don't care about who created the PR, only who decided to merge or close it.

jsmanrique commented 5 years ago

I'm asking about the second. I'll revise the first column to "Maintainer".

How many times has a "maintainer" clicked the "merge" button or "close" button (assuming the pr stays closed). The PR may have been opened by someone else and I don't care about who created the PR, only who decided to merge or close it.

So, you are asking for a third one 🤣

GeorgLink commented 5 years ago

🤯 It can be complicated to describe analyses - we need a CHAOSS metric for this to make it easier.

Well, is it possible with the current data in GrimoireLab or is new development needed?

alpgarcia commented 5 years ago

How many times has a "maintainer" clicked the "merge" button or "close" button (assuming the pr stays closed). The PR may have been opened by someone else and I don't care about who created the PR, only who decided to merge or close it.

We have the merger, so it is possible to get the number of PRs merged by a given author. What I think we don't have, and please @valeriocos correct me if I'm wrong, is the name of the person closing a PR.