Open Eroyi opened 2 weeks ago
Does it mean we can remove the other files that we have to deploy on kubernetes?
Absolutely, you may remove those deployment.yaml
files since the helm chart is now available for Kubernetes deployment.
But I must remind that helm charts, especially nested charts like this, are highly abstracted compared to the loose yaml file, which means it's more tricky to debug and hot-wire things.
I'll maintain this as long as I can, but highly recommend you get a helm chart specialist rather than rely on the community.
Could you also update the README file to explain a little bit more about how to configure and deploy it using helm. Also, all files don't end on an empty line. Please update them.
Sure, will do.
@Eroyi tell me when you think the PR is ready to review it.
@Eroyi tell me when you think the PR is ready to review it.
All of a sudden I failed to clone any GitHub repos from my Ubuntu, so I had to do things through the browser on github.com and Windows PC. Apologise for the messy commits.
Anyway I scrubbed all the Windows format toxics, LGTM now, please review.
This chart is tested in our Kubernetes cluster (with mariadb and redis installed separately).
Using helm chart to deploy: