search

chaoss / wg-metrics-models

Working Group for Metrics Model
MIT License
12 stars 22 forks source link

Added safety definition #44

Closed zhongjun2 closed 1 year ago

germonprez commented 2 years ago

Hi @zhongjun2

Thanks for the PR. A few comments:

1) Could you add a DCO sign-off for the PR 2) Could you place the markdown file in a /definition folder 3) I think you just include the metric and link to the metric in the Metrics in the Model section

zhongjun2 commented 2 years ago

Hi @zhongjun2

Thanks for the PR. A few comments:

  1. Could you add a DCO sign-off for the PR
  2. Could you place the markdown file in a /definition folder
  3. I think you just include the metric and link to the metric in the Metrics in the Model section

Done

Hi @zhongjun2

Thanks for the PR. A few comments:

  1. Could you add a DCO sign-off for the PR
  2. Could you place the markdown file in a /definition folder
  3. I think you just include the metric and link to the metric in the Metrics in the Model section

Done

eyehwan commented 2 years ago

@zhongjun2 Does this model include data insight?

zhongjun2 commented 2 years ago

@zhongjun2 Does this model include data insight?

The document does not yet present the data and associated analysis

germonprez commented 2 years ago

Hi @zhongjun2 -- Thanks for continuing to move this forward. A few more suggestions:

1) Could you simply provide a link to the metric used in the metric model? I don't think that we need the rich text below the link to the metric. 2) You could likely follow the suggestions from @eyehwan to remove the headers that are not being used. We can return to include them when we have a sample community to talk about.

zhongjun2 commented 1 year ago

Hi @zhongjun2 -- Thanks for continuing to move this forward. A few more suggestions:

  1. Could you simply provide a link to the metric used in the metric model? I don't think that we need the rich text below the link to the metric.
  2. You could likely follow the suggestions from @eyehwan to remove the headers that are not being used. We can return to include them when we have a sample community to talk about.

Added link to the metrics in the doc. Removed the headers that are not being used

eyehwan commented 1 year ago

Looks good to me!