search

chaoss / wg-value

CHAOSS Value Working Group
MIT License
39 stars 29 forks source link

Create organizational-influence.md #147

Closed vinodkahuja closed 3 years ago

vinodkahuja commented 3 years ago

Organizational Influence release candidate metric.

Signed-off-by: Vinod K. Ahuja vahuja@unomaha.edu

GeorgLink commented 3 years ago

Please fix DCO

Ideally, combine this PR with #148

vinodkahuja commented 3 years ago

@GeorgLink I have already provided "Signed-off-by: Vinod K. Ahuja vahuja@unomaha.edu" in my pull request but still, DCO fails it. It always does with my pull request. I am not sure what is the underlying cause.
Further, I created these PRs through Github web UI and it did not provide me the option to merge two patches in one PR.

GeorgLink commented 3 years ago

Combining changes in GitHub UI for only one PR: After creating the first PR, you can continue to edit the branch that was created and it will update that PR -- no need to create a new branch or a new PR.

DCO fails are curious. My guess is that your name or email address doesn't match your GitHub provile information that the bot compares with. I've had the issue of a minor name spelling leading to failed checks. -- I'll set your DCO check to "pass" since you have it included in the commit and I don't see the issue the bot has: Expected "Vinod K. Ahuja vahuja@unomaha.edu", but got "Vinod K. Ahuja vahuja@unomaha.edu".

vinodkahuja commented 3 years ago

@GeorgLink done. Please accept this PR and reject PR 148

GeorgLink commented 3 years ago

Done