search

chaostoolkit-incubator / chaostoolkit-aws

Chaos Toolkit Extension for AWS
https://chaostoolkit.org/drivers/aws/
Apache License 2.0
109 stars 52 forks source link

Fix `__all__` in `route53` #108

Closed ciaransweet closed 3 years ago

ciaransweet commented 3 years ago

The __all__ attribute was not correctly defined and was providing the following warning when running chaos discover chaostoolkit-aws:

[2021-08-03 12:10:40 INFO] Searching for probes in chaosaws.route53.probes
[2021-08-03 12:10:40 WARNING] 'chaosaws.route53.probes' does not expose the __all__ attribute. It is required to determine what functions are actually exported as activities.

Signed-off-by: Ciaran Evans ciaran@reliably.com

ciaransweet commented 3 years ago

@Lawouach I'm not sure if we test for __all__ being available as part of extension tests (I couldn't see any in this package at least)

Maybe we should do chaos discover and error if WARNING logs are output, in CI builds...