Closed HemantAHK closed 3 years ago
Hi @HemantAHK thanks for this code fix it nicely fixes the issue I was having with the WebApps! I am stuck though when I use the VMSS action. I get the error below, I have looked and looked at the code and for the life of me I can't work out what the issue is:
Traceback (most recent call last): File "/home/ian/.local/lib/python3.6/site-packages/chaoslib/provider/python.py", line 55, in run_python_activity return func(**arguments) File "/home/ian/.local/lib/python3.6/site-packages/chaosazure/vmss/actions.py", line 88, in restart_vmss configuration, secrets) File "/home/ian/.local/lib/python3.6/site-packages/chaosazure/vmss/fetcher.py", line 17, in fetch_instances scale_set, configuration, secrets) File "/home/ian/.local/lib/python3.6/site-packages/chaosazure/vmss/fetcher.py", line 87, in __random_instance_from scale_set, configuration, secrets) File "/home/ian/.local/lib/python3.6/site-packages/chaosazure/vmss/fetcher.py", line 65, in __fetch_vmss_instances client = init_compute_management_client(secrets, configuration) File "/home/ian/.local/lib/python3.6/site-packages/chaosazure/__init__.py", line 49, in init_compute_management_client base_url=base_url) TypeError: __init__() missing 1 required positional argument: 'credential'
I am using the Environment Variable approach for secrets and the configuration works fine for the WebApps. Any clues as to what I may be doing wrong?
Thank you
Hey, Hi @ianalderman it seems like you have not included credentials or you might have not added the correct credentials in your experiment. Please do check it once.
Thanks @HemantAHK I think it must have something to do with my environment. Reading the python SDK releases there is a breaking change to the argument definitions for the compute client from credentials to credential. If I change that it gets past this, I then end up in a world of hurt as the fetcher runs into issues with a change to the underlying library there too :) I think I will quit whilst I am ahead
oh don't hesitate to rebase/squash/force push :)
It looks good to me. Can you make a final squash of all your commits please? I should be able to merge then.
Done! with the final Squash.
This fixes the handling of the below-attached Image.
Created a Sperate Function which handles WebSiteManagementClient and now this function is called by all actions present in the Webapp module.