search

chaostoolkit-incubator / chaostoolkit-azure

Chaos Toolkit Extension for Azure
https://chaostoolkit.org/
Apache License 2.0
22 stars 28 forks source link

Fixing the SPN authentication issue and upgrading all azure libraries… #130

Closed aravindarc closed 3 years ago

aravindarc commented 3 years ago

… to recent version(as of this commit), with versions mentioned in requirements.txt for proper tracking.

This was tested manually using chaos tool also, the SPN issue was resolved and also the experiments are working as expected.

129 is related to this issue.

The problem was requirements.txt had no versions, because of which latest libraries are being used, which in turn contains breaking changes in apis.

The solution: I upgraded all libraries to use recent version and made the changes required. Following this documentation https://docs.microsoft.com/en-us/azure/developer/python/azure-sdk-overview#migrating-from-older-management-libraries

I have also marked the versions in the requirements.txt to prevent any future version related issue.

Signed-off-by: Aravinda Kumar aravindrckumar@gmail.com

aravindarc commented 3 years ago

@Lawouach @bugra-derre Can you please verify this PR and merge it. This is a show stopper for me and the issue is existing for a while

Lawouach commented 3 years ago

Looking at this now :)

aravindarc commented 3 years ago

@Lawouach About the changelog entry, there is already an entry in the top marked as unreleased, what should be done about this. Also should I increase the version, if yes what should be the version, or will this be done by you.

Lawouach commented 3 years ago

Add new entries under the "unreleased" section under Changed/Added. Do not bump the version. I'll do that when I release after merging.

aravindarc commented 3 years ago

@Lawouach I have made the requested changes