search

chaostoolkit-incubator / chaostoolkit-azure

Chaos Toolkit Extension for Azure
https://chaostoolkit.org/
Apache License 2.0
22 stars 28 forks source link

postgresql flexible - deleting tables #153

Closed SupDavid closed 1 year ago

SupDavid commented 1 year ago

Hello @Lawouach , I had some problems with the previous pull request, I created a new one.

I added the signature of my commits, I optimized the number of line and I added the line break at the level of the imports in the action file.

I think we're good!

SupDavid commented 1 year ago

Hi @Lawouach , I'm taking the liberty of getting back to you on this pull request, we need to integrate this feature into chaos toolkit for an operation next week and a few preparations are still needed. Our timing is pretty tight...

I'd really appreciate it if you could make this happen quickly :)

Lawouach commented 1 year ago

Hi @SupDavid

I'll allow it for today but I'll have to fix a couple of things after merging. I think it's important you keep me updated ahead of time when you have deadlines :)

I'm on holiday so I'm taking time for this. I'd rather I knew a bit before hand so we could decide if there was a risk for you.

Lawouach commented 1 year ago

Hi @SupDavid and @jbblache

I've merged and fixed the code linting (please consider running pylama chaosazure before pushing in the future). However the tests aren't passing.

Please send another PR fixing them so I can cut a release.