chaostoolkit-incubator / chaostoolkit-azure

Chaos Toolkit Extension for Azure
https://chaostoolkit.org/
Apache License 2.0
22 stars 28 forks source link

Discussion: Separate the chaostoolkit-azure extension in two extensions #49

Closed buderre closed 5 years ago

buderre commented 5 years ago

The ct-azure extension hosts actions for i) the Azure Service Fabric and ii) the Azure infrastructure.

The Azure Service Fabric is an orchestration framework, comparable to K8s. Microsoft states that Service Fabric is portable, and can be deployed on for example AWS.

Some main points for the discussion of separating those two parts:

From the ct clients' point of view, it could also be beneficial to see, that ct supports Azure and Azure Service Fabric.

What do you think?

Lawouach commented 5 years ago

Hey @buderre

I can see the rationale for this completely. I think it showed my lack of understanding of Azure when I created the extension later on.

Might be useful to ping @seriousscorpion @matsch55 and @mkaszub as they contributed to the extension, so it would be cool to have their feedback and awareness :)

mkaszub commented 5 years ago

Hey @buderre That's a good point. As Service Fabric is cloud independent it most likely should not be in azure extension.

buderre commented 5 years ago

I would not like to throw it away. It could be a positive option to separate it in two extensions - the Azure and the Service Fabric extension? This suggestion could on one side help us in the technical approach to separate those two extensions and on the other side increase the users' awareness for the Azure infrastructure extension.

This could have the charmant effect to update https://chaostoolkit.org/extensions with an additional extension and have two: Azure and Service Fabric as an extension.

I'm wondering what you think about this @mkaszub @Lawouach

Lawouach commented 5 years ago

If you folks feel like it's the right path, I'm more than happy to create a new repo called chaostoolkit-azure-service-fabric. It's a mouthful but clear :)

matsch55 commented 5 years ago

That sounds good, but I would call it chaostoolkit-service-fabric, because service-fabrics could also be deloyed on AWS (https://docs.microsoft.com/en-us/azure/service-fabric/service-fabric-tutorial-standalone-create-infrastructure).

Lawouach commented 5 years ago

Sounds good by me! I'll create it now.

Lawouach commented 5 years ago

Done https://github.com/chaostoolkit-incubator/chaostoolkit-service-fabric

Lawouach commented 5 years ago

You may copy this extension over and clean it up as a PR. Or use a template project and start from scratch https://github.com/dastergon/cookiecutter-chaostoolkit

buderre commented 5 years ago

Nice one. Like it.