search

chaostoolkit-incubator / chaostoolkit-azure

Chaos Toolkit Extension for Azure
https://chaostoolkit.org/
Apache License 2.0
22 stars 28 forks source link

Implement the discovery function for the Azure extension #7

Closed bugra-derre closed 6 years ago

bugra-derre commented 6 years ago

Resolves: #6

bugra-derre commented 6 years ago

@Lawouach : I am a little bit confused. I am in trouble with the Merge pull request commit and even worse I am not a Git pro. Is the way I am doing PR via forking a good way? Or should I just open a branch on the original project here?

russmiles commented 6 years ago

@bugra-derre did you mean to close this issue without merging?

Lawouach commented 6 years ago

No worries @bugra-derre. If your changes are the right ones, simply open up the PR again. The only change I'd like to add is an entry to the changelog. You can make a separate commit for this and we will squash everything during the merge into master.

bugra-derre commented 6 years ago

@Lawouach I did another PR. You can close this one. Sorry for my "professional" PR :)