Support Azure China Cloud and other

[xpdable]

One possible solution for #70

[xpdable]

Generally I don't like these too many duplicated entries, code snippets and imports. Possible to wait @buderre back from vacation.

[Lawouach]

Indeed.

[xpdable]

@buderre @Lawouach Yep, that is what worth to talk. Field azure_cloud is indeed not secret. However, if we put it into configuration, we need some more refactoring as the method of

def auth(secrets: Secrets) -> ServicePrincipalCredentials: 
...

def __get_credentials(creds):
    credentials = ServicePrincipalCredentials(
        client_id=creds['azure_client_id'],
        secret=creds['azure_client_secret'],
        tenant=creds['azure_tenant_id'],
        cloud_environment=eval("msrestazure.azure_cloud.{}"
                               .format(creds['azure_cloud']))
    )
    return credentials

May need to accept configuration as well. And all of the invokes of auth(secrets) may need to updates :) Free to talk if we do more changes on this :P

[buderre]

I see now. The Service Principal needs them as credential data. Maybe I'm wrong and the cloud_environment is part of (un)secret credentials :) Maybe you just go on. +1 from me. Don't forget the commits to squash and make them one commit only.

[xpdable]

Thanks @buderre , @Lawouach Since we are all on the same page, shall we move on to next step to merge the PR?

[Lawouach]

Appreciate the discussion here :)

To review though, I would very much like a single squashed commit please.

[xpdable]

Squashed, and let's review again

[buderre]

Can you enhance the CHANGELOG file and write your changes in a single line?

[xpdable]

@Lawouach @buderre some changes on the client init, need more review of this. The big benefit that no need to change more duplicates when we need more change on client init. eval() is also change to the function __get_cloud_env_by_name to avoid any risk. Meanwhile, I need to manage sometime on implementing more test of above.

[xpdable]

@buderre @Lawouach As I moved some init_client function to __init__.py, I do sincerely request you review on this.