search

chaostoolkit-incubator / chaostoolkit-azure

Chaos Toolkit Extension for Azure
https://chaostoolkit.org/
Apache License 2.0
22 stars 28 forks source link

Add ability to stress virtual machine scale set instances #77

Closed maximmold closed 4 years ago

maximmold commented 4 years ago

This PR could definitely use some DRY principle cleanup, but it should be a good starting point.

Lawouach commented 4 years ago

Would it be possibel to squash it for a first review please?

xpdable commented 4 years ago

quick question with no check. Would machine actions still work if all script folder is moved? https://github.com/chaostoolkit-incubator/chaostoolkit-azure/blob/dcab325b70fd8ec84176a644314c32710fb804d7/chaosazure/machine/actions.py#L233

buderre commented 4 years ago

quick question with no check. Would machine actions still work if all script folder is moved? https://github.com/chaostoolkit-incubator/chaostoolkit-azure/blob/dcab325b70fd8ec84176a644314c32710fb804d7/chaosazure/machine/actions.py#L233

No. The scripts need to be included in the MANIFEST.in file. Else it won't work. @maximmold I like the approach to make it more local. Can you please test the bundled package locally and test whether it works or not?

maximmold commented 4 years ago

Sorry. That was definitely my intention to go back and update the machine package to point to the new directory, but I forgot to do it.

maximmold commented 4 years ago

Ahha! I'm used to an editor with autosave mode and did not save the actions file under the machines package.

Lawouach commented 4 years ago

Hey @maximmold I'm assuming the last commit is part of the other you pushed initially. Could you squash them all and force push by any chance?

maximmold commented 4 years ago

I tested the stop_machines action with the changes above and it still worked.

buderre commented 4 years ago

@maximmold Can you update the CHANGELOG.md with your changes to document the changes for other users?

maximmold commented 4 years ago

I'll try to hit this up next week.

maximmold commented 4 years ago

Should be good now.

Lawouach commented 4 years ago

Well yes and now. Now, I don't fully understand what your changes do. The first commit is a merge commit and the last one removes the init_client function. I don't quite understand what this PR does now.

Are you on the slack at https://join.chaostoolkit.org/ by any chance? I hate to being a pain but maybe we should get on a quick chat there so I fully grasp the two PRs :)