search

chaostoolkit-incubator / chaostoolkit-azure

Chaos Toolkit Extension for Azure
https://chaostoolkit.org/
Apache License 2.0
22 stars 28 forks source link

Refactoring the module structure #95

Closed bugra-derre closed 4 years ago

bugra-derre commented 4 years ago

@Lawouach I would like to do a refactoring on the module structure.

Modules such as vm, vmss, and webapp have more or less similar (but not the same) actions. I would like to structure

from

.
├── vm
│  ├── actions.py
├── vmss
│  ├── actions.py
├── webapp
│  ├── actions.py

to

.
│  compute
│  ├── vm
│  │  ├── actions.py
│  ├── vmss
│  │  ├── actions.py
│  ├── webapp
│  │  ├── actions.py

Would such a structure hurt somewhere e.g. the documentation generation?

Lawouach commented 4 years ago

Hey @bugra-derre

I think that is fine but the documentation is not so much a problem (it's easy to change). However, this will break all existing experiments using this extension.

One way would be to keep a helper function at the top of chaosazure/__init__.py that catches old calls and issue a deprecation warning.

bugra-derre commented 4 years ago

Ahh. True story. Okay. I think I will leave it as is and close this story.