search

chaostoolkit-incubator / chaostoolkit-slack

Chaos Toolkit Plugin for Slack
Apache License 2.0
6 stars 2 forks source link

Fix slackclient package version to 1.3.1 #2

Closed Devatoria closed 5 years ago

Devatoria commented 5 years ago

In the new slackclient package versions, you can't import the module with the name slackclient but should use slack instead:

>>> import chaosslack.notification
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python3.6/site-packages/chaosslack/notification.py", line 7, in <module>
    from slackclient import SlackClient
ModuleNotFoundError: No module named 'slackclient'

Since I don't know what are the other changes with versions >= 2.0.0 yet, here's a quick fix.

russmiles commented 5 years ago

Thanks @Devatoria, could you also sign the commit for this PR please?

Devatoria commented 5 years ago

Hi folks, any news about this one please?

Lawouach commented 5 years ago

Sorry. Being at KubeCon meant I wasn't quite ready for this one yet.

Looks GTM :)