search

chaostoolkit / chaostoolkit-documentation

The Chaos Toolkit documentation
https://chaostoolkit.org
Apache License 2.0
19 stars 32 forks source link

Document the --hypothesis-strategy cli param #106

Closed adamdabbracci closed 3 years ago

adamdabbracci commented 3 years ago

Signed-off-by: Adam D'Abbracci adamdabbracci@adams-mbp.lan

ciaransweet commented 3 years ago

@adamdabbracci 👋 Just a reminder that you need to DCO sign every commit you push!

If you're a frequent contributor to our repos, what I've done is setup a commit template in my chaostoolkit/ dir with:

Signed-off-by: Ciaran Evans <ciaran@reliably.com>

In a file called chaostoolkit-commit-template.txt

You can then set it to just the local dir by:

git config --local commit.template fully/qualified/path/to/template/file
adamdabbracci commented 3 years ago

Whoops! I committed your fix directly from the UI, so I completely forgot about the DCO. I've tried to sign it for that commit, but it doesn't seem to be picking up, so I must be missing something obvious.

Checkout the PR: gh pr checkout 106 -R chaostoolkit/chaostoolkit-documentation

Sign off: git commit --amend --no-edit --signoff

Push: git push --force-with-lease origin add-hypothesis-strategy

ciaransweet commented 3 years ago

I wonder if it's something silly like we're both on the commit or something! I'll have a look!

ciaransweet commented 3 years ago

@adamdabbracci are you signing off with an email that is available on your GitHub Account?

Just looking at the UI above, the pushes are assigned to you, but the commits appear to be profile-less

Can you double check that your email is listed here https://github.com/settings/emails?

adamdabbracci commented 3 years ago

I'm going to close this PR and open a new one... with the signature correct from the beginning hopefully... thank you for trying to troubleshoot!