Removed broken static svg link

chaostoolkit / chaostoolkit-documentation

The Chaos Toolkit documentation

https://chaostoolkit.org

Apache License 2.0

19 stars 32 forks source link

Removed broken static svg link #69

Closed russmiles closed 3 years ago

russmiles commented 5 years ago

Possibly just for now...

Closes #61

Signed-off-by: Russ Miles russ@russmiles.com

dmartin35 commented 5 years ago

isn't it supposed to be the same image as on the chaostoolit.org main page ? https://chaostoolkit.org/static/chaostoolkit-schema-835b2c8a4c19fa8c10d0ae2b43bbb69a.svg

If so, we might duplicate it on this repo, as the hash of the image might change when re-deploying the website ?

Lawouach commented 5 years ago

The trick is indeed that the source image changes everytime the www website is rebuilt. Three options:

we remove it (this PR)
we make a static version that is comitted once and for all in this repo
we update this repo everytime the other repo is rebuild (harder and little value since the image never changes)

russmiles commented 5 years ago

I'm happy with a static version to be generated and checked in, if that's straightforward? I'm not clear how to do it.

Lawouach commented 5 years ago

me neither :) probably need to ping @mperrien tomorrow

SuperKogito commented 4 years ago

I think broken links are a common issue and a radical solution to this problem is automatically checking and reporting them. Luckily the new GitHub actions and workflows help with that. I recently wrote an action that just does that. URLs-checker will check and report broken links, which is useful to spot similar issues to this one.

ciaransweet commented 3 years ago

@Lawouach good to ☠️ ?

Lawouach commented 3 years ago

I think we can indeed.