search

chaostoolkit / chaostoolkit-lib

The Chaos Toolkit core library
https://chaostoolkit.org/
Apache License 2.0
77 stars 46 forks source link

Resolves #210 #234

Closed Tam-Lin closed 3 years ago

Tam-Lin commented 3 years ago

The tests are taking advantage in some places of os.environ being a global namespace. They check to make sure that KUBE_API_URL is set to "http://1.2.3.4", but they don't actually explicitly set it. Plus, os.environ is a system call, so it really should be mocked, not set in the testcase itself.

Signed-off-by: Kevin McKenzie kmckenzi@us.ibm.com

Tam-Lin commented 3 years ago
Not sure how those ended up there. I removed the git annotations and repushed.
ciaransweet commented 3 years ago

@Tam-Lin Going to close this one as you make another PR which is now in.