search

chaostoolkit / chaostoolkit-lib

The Chaos Toolkit core library
https://chaostoolkit.org/
Apache License 2.0
76 stars 46 forks source link

Resolves issue #209 #235

Closed Tam-Lin closed 3 years ago

Tam-Lin commented 3 years ago

This allows for indefinitely nested secrets files. I also address #212, so if you override a secret loaded from a vault, it will be overridden the same way a secret loaded from the environment is overridden. This is for consistency’s sake, but if there’s a reason to preserve the old behavior, that could be done. I also made some changes to a couple of testcases to use the load_secrets function as opposed to the load_secrets_from_vault function.

Signed-off-by: Kevin McKenzie kmckenzi@us.ibm.com

ciaransweet commented 3 years ago

@Tam-Lin thanks for the PR!

Currently your build is falling on Linting (A make format should fix this, unless there's unused variables/imports), also, could you add a ChangeLog entry please?

Tam-Lin commented 3 years ago

It was an extraneous import, which I removed. I also added a ChangeLog entry.

ciaransweet commented 3 years ago

@Tam-Lin many thanks for the great PR! Sorry it's taken so long to get it in, but thank you so much for being a good sport and following the repo as it moved on, we appreciate it! ❤️