after_activity_control state.status is "succeeded" but probe tolerance wasn't met

[WixoLeo]

Whenever "after_activity_control" being invoked, doesn't matter if probe's tolerance is met or not, the status is always "succeeded".

Question is if it's intended to be this way or should it be failed only if a probe raises and exception? If it's intended, then it would be great to have a tolerance status as well.

Runtime versions

Python 3.9.2
NAME                VERSION   
CLI                 1.10.0    
Core library        1.22.1

To Reproduce

• Clone and enter the repository:

  git clone git@github.com:WixoLeo/ctk-tests.git && cd ctk-tests

• Checkout this branch:

  git checkout activity-result

• Create python environment:

  virtualenv venv

• Activate environment:

  source venv/bin/activate

• Install requirements:

  pip install -r requirements.txt

• Install chaostoolkit example plugin

  pip install -e ./playground-plugin

• Run the experiment:

  chaos run exp.json

Expected behavior If tolerance of a probe did not met, expected to see the "status" to be "tolerance-not-met" or something like that.

Additional context In the example repo I've provided minimal experiment with minimal plugin in order for you to run locally with ease. It contains the following:

• exp.json - the experiment it's self
• playground-plugin - a custom minimal extension for the CTK

Playground plugin contains the following:

• probes.py - that has a very simple probe "some_probe"
• control.py - that has one event "after_activity_control" that prints the state.status.

[github-actions[bot]]

This Issue has not been active in 365 days. To re-activate this Issue, remove the Stale label or comment on it. If not re-activated, this Issue will be closed in 7 days.

[github-actions[bot]]

This Issue was closed because it was not reactivated after 7 days of being marked Stale.